Skip to content

DOCSP-49095: Retryable Reads and Writes #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 10, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49095

Staging Links

  • crud/configure
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 10, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit c0ec14d
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67ffafca321608000831eb19
    😎 Deploy Preview https://deploy-preview-585--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Amazing, LGTM w/ a few suggestions!

    @mcmorisi mcmorisi requested review from a team, JamesKovacs and papafe and removed request for a team and JamesKovacs April 10, 2025 14:56
    :language: csharp
    :dedent:

    To learn more about supported retryable read and retryable write operations, see
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Not sure if it would be worth mentioning here or if there is a more appropriate place, but should also say that those can be set already in the connection string?

    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Overall it looks good. Just a small question

    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Overall it looks good. Just a small question

    @mcmorisi mcmorisi requested a review from papafe April 16, 2025 13:30
    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit c0ae698 into mongodb:docsp-45382-comp-cvg Apr 16, 2025
    6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants